Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 changes:
Capybara::ElementNotFound
underAePageObjects::LoadingElementFailed
.AePageObjects::LoadingElementFailed
indicates that anAePageObjects::Element
failed to load.Capybara::ElementNotFound
indicates that a Capybara element failed to be found. The Capybara exception should only be nested under the AePageObjects exception when the Capybara exception is the cause for an AePageObjects element failing to load.find()
delegation in Node withnode.find()
. In every case, Node wants to find the underlying Capybara element. Before this change, subclasses could define afind
method and override the behavior in Node of finding the underlying Capybara node. For example,AePageObjects::Collection
does this today. Subclasses should be able to define methods without overriding this behavior.