Chapter 03 - Fix 'label: false' #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using: ```rails generate simple_form:install --foundation```
... hiding the label.
|
Hey, thanks @abinoam ❤️ I decided that I don't want to promote SimpleForm anymore and in the next book we will use Formular. |
|
No problem! 👍 Still slowly re-reading Trailblazer book. More to come! Em Qua, 15 de jun de 2016 06:26, Nick Sutterer [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @apotonick,
I have updated the Simple Form Foundation templates and trimmed the repetitive 'label: false' from some views.
I have also used locale files to define placeholders.
After I have began to work on this I could notice that @smathy have already worked on it on PR #9. But unfortunately his branch is stale and with conflicts.
I have also walked through each chapter from 3 to 11 merging the changes from the previous chapter and fixing anything new that appears on each chapter.
I have fixed the "no labels" issue on chapter-10 as your comment at #9 (comment)
I'm opening this PR for chapter-03 branch. But I don't know if you want me to open a PR for each chapter branch or you're gonna just fetch my repo and merge locally.
Each branch comes from its corresponding chapter branch and can be merged without conflicts.
All branches ends with
feat-fix-formSee: https://github.com/abinoam/gemgem-trbrb/branches/active