Merge pull request #15 from grEvenX/fix_status_code_error

Fix failure to return correct status code in Response
aporat · Mar 3, 2015 · 9a3044c · 9a3044c
2 parents d96fb75 + 2391be4
commit 9a3044c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/ReceiptValidator/iTunes/Response.php b/src/ReceiptValidator/iTunes/Response.php
@@ -223,6 +223,8 @@ public function parseJsonResponse($jsonResponse)
                     $this->_bundle_id = $jsonResponse['receipt']['bid'];
                 }
             }
+        } elseif (array_key_exists('status', $jsonResponse)) {
+            $this->_code = $jsonResponse['status'];
         } else {
             $this->_code = self::RESULT_DATA_MALFORMED;
         }

diff --git a/tests/iTunes/ResponseTest.php b/tests/iTunes/ResponseTest.php
@@ -19,13 +19,23 @@ public function testInvalidReceipt()
         $response = new Response(array('status' => 21002, 'receipt' => []));
 
         $this->assertFalse($response->isValid(), 'receipt must be invalid');
+        $this->assertEquals(21002, $response->getResultCode(), 'receipt result code must match');
     }
 
+    public function testReceiptSentToWrongEndpoint()
+    {
+        $response = new Response(array('status' => 21007));
+
+        $this->assertFalse($response->isValid(), 'receipt must be invalid');
+        $this->assertEquals(21007, $response->getResultCode(), 'receipt result code must match');
+    }
+
     public function testValidReceipt()
     {
         $response = new Response(array('status' => 0, 'receipt' => []));
 
         $this->assertTrue($response->isValid(), 'receipt must be valid');
+        $this->assertEquals(0, $response->getResultCode(), 'receipt result code must match');
     }
 
 }