Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor TD004 into multiple different plugins #478

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

DinoChiesa
Copy link
Collaborator

@DinoChiesa DinoChiesa commented Sep 27, 2024

The prior TD004, which checked all sorts of combinations of configuration problems in HTTPTargetConnection, is now refactored into 5 distinct plugins, each of which is smaller and more focused.

  • TD004 - Enabled + Enforce on SSLInfo
  • TD011 - IgnoreValidationErrors is not present or false
  • TD012 - exactly one SSLInfo element
  • TD013 - hygiene w.r.t. ClientAuthEnabled
  • TD014 - exactly one URL or LoadBalancer element
  • TD015 - check for MaxFailures when LoadBalancer is present

This addresses #459

@DinoChiesa DinoChiesa marked this pull request as draft October 7, 2024 17:11
@DinoChiesa DinoChiesa marked this pull request as ready for review October 7, 2024 17:22
@DinoChiesa DinoChiesa merged commit 4e64b92 into apigee:main Oct 7, 2024
2 checks passed
@DinoChiesa DinoChiesa deleted the td004-refactor branch October 7, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant