refactor: Simplify request queue implementation #653
Conversation
janbuchar
added
the
t-tooling
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
|
I was hoping we would first address this in the JS version where its actually costing us money, do we have some reported problems on the python side too? |
I get your angle, but I wanted to try it on code where the implementation isn't scattered between |
|
If that abstraction is problematic I am fine with removing it and leaving the base class acting like an interface mostly (we can't just make it one as that would be technically breaking), duplication is not a huge deal if we plan to drop the RQ v1 implementation anyway - but first we need to make sure v2 is working fine, we still get peeps from delivery moving back to v1 to deal with those weird issues... |
...and all of the above is why I chose to validate the points by Kuba in the python version 😄 |
|
My issue is that not many people use the python version, and those issues reported by delivery are quite random, so hard to confirm something helps here. Maybe it will resolve the issue we have a repro for here, that's great, but it might be a different one than those where we actually bleed money (we usually refund people with stuck runs completely). I am fine doing it first here, but let's not wait for some confirmation before trying to fix it in the JS version. |
Follow up on the points raised in apify/crawlee#2700