Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn for missing targets #659

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Warn for missing targets #659

merged 7 commits into from
Oct 30, 2024

Conversation

thim81
Copy link
Collaborator

@thim81 thim81 commented Sep 28, 2024

linked to #632 #391

Result:
image

@thim81
Copy link
Collaborator Author

thim81 commented Sep 28, 2024

@nicklloyd

Not sure, what should be the default --warn true or false?

Or this should be default, with an "--strict" instead of "--warn"?

@thim81 thim81 changed the title Warn for missing openApiOperationId Warn for missing targets Sep 28, 2024
@thim81
Copy link
Collaborator Author

thim81 commented Oct 9, 2024

@jpjpjp Got any feedback about the expected behaviour and/or need of having --warn or --strict?

@jpjpjp
Copy link
Contributor

jpjpjp commented Oct 10, 2024

@jpjpjp Got any feedback about the expected behaviour and/or need of having --warn or --strict?

TBH, I'm not sure where the --warn or --strict options come into play. (Are these documented?)

What I like about the behavior as demonstrated in the screenshot is that the collection is still written but at the end of the output you get a clear message that it includes references to undefined "stuff". There may be circumstances where you are writing tests in advance of implementation where this is expected, but I think its ALWAYS good to know that it is occuring.

@thim81 thim81 merged commit 673d887 into main Oct 30, 2024
6 checks passed
@thim81 thim81 deleted the 632-warn branch October 30, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants