Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portman error exit code #594

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Portman error exit code #594

merged 1 commit into from
Jul 8, 2024

Conversation

Matt2212
Copy link
Contributor

  • changed the exit code to a non zero value

* changed the exit code to a non zero value
@thim81
Copy link
Collaborator

thim81 commented Jun 28, 2024

hi @Matt2212

Thanks for the PR and correcting the exit code.
Where did you ran into it? Was it in a pipeline or local usage?

Do you have an opinion what the exit code should be for Newman?
#530

In case Newman fails, should it stop further processing or not?

@thim81 thim81 self-requested a review June 28, 2024 09:52
@Matt2212
Copy link
Contributor Author

hi @thim81,
i ran portman into a pipeline. During the execution there was a "Portman Error" but the pipeline did not stop. Maybe the best solution is to codificate each possible error with a specific code and add to the function that i modified an additional parameter which is the exit code. Otherwise the function could exit with a non zero value in order to stop any pipeline if there is an error.

@thim81 thim81 merged commit fb35bae into apideck-libraries:main Jul 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants