Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for the Angular compiler. #4691

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeroen1602
Copy link

New Pull Request

The Angular compiler looks for the main field using a few fields in the package.json. The order it uses is:

  • es2020
  • es2015
  • browser
  • module
  • main

The first entry the Angular compiler would find before this change was the 'main' entry point. This is however compiled as common js and Angular is looking for an esm so it would complain (it would still work though). Adding es2020 as an entry point fixes this problem.

Fixes ng-apexcharts#92

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My branch is up to date with any changes from the main branch

The Angular compiler looks for the main field using a few fields in the package.json. The order it uses is:
- es2020
- es2015
- browser
- module
- main

The first entry the Angular compiler would find before this change was the 'main' entry point. This is however compiled as `common js` and Angular is looking for an `esm` so it would complain (it would still work though). Adding `es2020` as an entry point fixes this problem.
@jeroen1602
Copy link
Author

Using module in the package.json may be more correct and also help other compilers. But I couldn't really find any good documentation on it.

@junedchhipa
Copy link
Contributor

We disabled esm builds because we had some issues in the past. The export from Svg.js is being exported instead of ApexCharts. We are in the process of upgrading svg.js and that will potentially fix the export issue. Once it is done, I will revisit this PR

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning In angular 10
2 participants