Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified " help us improve" link #498

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

satti-hari-krishna-reddy
Copy link
Contributor

reference #405

the version number just below help us improve link is actually directing to https://github.com/apertium/apertium-html-tools
but i think many users wont even recognise that it is a clickable tag , most of them click on help us improve ,but that is opening AboutModal instead which isnt that helpful to report any issues .

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8409404233

Details

  • 27 of 28 (96.43%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 97.618%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/util/initialTextValues.tsx 13 14 92.86%
Totals Coverage Status
Change from base Build 8354222802: -0.03%
Covered Lines: 1400
Relevant Lines: 1416

💛 - Coveralls

@satti-hari-krishna-reddy
Copy link
Contributor Author

@sushain97 , i fixed the merge conflicts

@satti-hari-krishna-reddy
Copy link
Contributor Author

if we can fix this issue then #482 can be fixed very easily

<a
className="p-0"
href={`https://github.com/apertium/apertium-${
languagePair ?? 'default'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is apertium-default?

className="p-0"
href={`https://github.com/apertium/apertium-${
languagePair ?? 'default'
}/issues/new?title=Suggested+translation+improvement&body=SOURCE: ${srcText}%0A%0AGOT: ${tgtText}%0A%0AEXPECTED: %20%5BYOUR%20TRANSLATION%20SUGGESTION%20GOES%20HERE%5D`}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this end up looking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants