-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified " help us improve" link #498
base: master
Are you sure you want to change the base?
modified " help us improve" link #498
Conversation
Pull Request Test Coverage Report for Build 8409404233Details
💛 - Coveralls |
@sushain97 , i fixed the merge conflicts |
if we can fix this issue then #482 can be fixed very easily |
<a | ||
className="p-0" | ||
href={`https://github.com/apertium/apertium-${ | ||
languagePair ?? 'default' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is apertium-default?
className="p-0" | ||
href={`https://github.com/apertium/apertium-${ | ||
languagePair ?? 'default' | ||
}/issues/new?title=Suggested+translation+improvement&body=SOURCE: ${srcText}%0A%0AGOT: ${tgtText}%0A%0AEXPECTED: %20%5BYOUR%20TRANSLATION%20SUGGESTION%20GOES%20HERE%5D`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this end up looking?
reference #405
the version number just below help us improve link is actually directing to https://github.com/apertium/apertium-html-tools
but i think many users wont even recognise that it is a clickable tag , most of them click on help us improve ,but that is opening AboutModal instead which isnt that helpful to report any issues .