Fix: Ensure Footer Visibility on Smaller Screens

[thrishank]

Summary

#468 Issue
This pull request addresses an issue where the footer was not rendering on smaller screens due to the d-none class. The visibility of the footer is crucial for providing a seamless user experience across different devices.

Changes Made

• Removed the d-none class from the div in the footer folder index file, enabling the footer to be visible on smaller screens.

Why

The d-none class was unintentionally hiding the footer on smaller screens, affecting the overall user experience. This change ensures consistent visibility across all screen sizes. The d-none class in Bootstrap is a utility class that sets an element to display: none! important;, effectively hiding it.

ScreenShots

before

After

• Tested on various devices and screen sizes.
• Ensured the removal of the d-none class did not introduce any unintended side effects.

This PR is ready for review. Your feedback is appreciated!

[sushain97]

Unfortunately, this is exceptionally noisy UI for a mobile screen and displays redundant content ("Spotted a mistake..." appears twice).

[thrishank]

Hey @sushain97 thanks for the feedback. I have removed the redundant content.

Should I work on a clean UI ?

[sushain97]

That would be necessary to have this merged.

[thrishank]

@sushain97 is this okay or should I make any additional changes?

[sushain97]

This is still far too much vertical space. Try looking at how other websites handle collapsing a footer on mobile viewports?

[thrishank]

https://github.com/apertium/apertium-html-tools/assets/86158204/45f451d7-6b92-4b27-9262-303be0ebb03b
Reduced the vertical space a little bit.

[sushain97]

Why did you add "github" here & an icon? I think it was nice to have this be minimal.

[thrishank]

Sorry, removed it. Just thought it would be good to have icon.

[sushain97]

Looks like a test needs to be updated!

[thrishank]

In the Footer test suite, the "opens about dialog on desktop" test was failing due to accessing an undefined element at index 1 in the buttons array. Upon investigating I found that there is only one element in the buttons array. The issue was resolved by updating the index to 0, ensuring the test clicks on the correct button.
@sushain97

[coveralls]

Pull Request Test Coverage Report for Build 8161043384

Details

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.001%) to 97.644%

---

Totals
Change from base Build 8032731524:	-0.001%
Covered Lines:	1381
Relevant Lines:	1396

---

💛 - Coveralls

[thrishank]

Hey @sushain97 I am thinking of participating for apertium GSoC. Who should I contact ?

Thank You

[ahmedsiam0]

Hi @thrishank,

You can introduce yourself and share your interest about a specific project through IRC or the mailing list.
You will find more info about them here: https://wiki.apertium.org/wiki/Contact

If you have any questions, you can use those communication methods to ask them.
You should prefer public communication methods (Like the IRC channel and the mailing list) over private ones like communicating with a specific mentor privately through emails.

Useful articles about communicating:
https://google.github.io/gsocguides/student/making-first-contact
https://google.github.io/gsocguides/student/communication-best-practices

Good Luck.