Drop Python 2.6, add Python 3 test compatibility #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that file opjects for stdin etc. are opened in text mode for Python 2 & 3 compatability.
- Add universal_newlines for Python 3 compatability with Python 2 strings. - Unpick entablement of the two Popen calls as using communicate() is best practice over writing to streams directly. (This was also incompatible with Python 3.)
- This is no longer needed as there's no need to support versions of Python older than 2.6 and the ssl module is no longer used in this file anyway.
qopri.encodestring() only accepts bytes objects and encodestring() and decodestring() both output bytes objects in Python 3. To maintain compatibility with Python 2, this requires encoding the input to encodestring to bytes (a no-op on Python 2) and then checking to see if we need to decode on the other side (which will depend on the version of Python).
gregcorbett
reviewed
Jan 27, 2020
gregcorbett
reviewed
Jan 27, 2020
gregcorbett
reviewed
Jan 27, 2020
Co-Authored-By: gregcorbett <[email protected]>
gregcorbett
approved these changes
Jan 29, 2020
|
I accept your ambivalence. ⚖️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #91.
N.B. Removes support for Python 2.6. So we'll need to go up a major (!) version number for the next release.
This pull request adds basic Python 3 compatibility such that the Travis tests can run successfully. There are certainly other things that will need fixing to ensure SSM actually works with Python 3 (including
optparsedeprecation).References for
quoprichanges:Python 2
Python 3