chore: forbidden vars value and valueFrom are specified #8635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyelei
approved these changes
Dec 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8635 +/- ##
==========================================
- Coverage 60.49% 60.41% -0.08%
==========================================
Files 378 378
Lines 45623 45626 +3
==========================================
- Hits 27598 27567 -31
- Misses 15441 15477 +36
+ Partials 2584 2582 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leon-inf
reviewed
Dec 13, 2024
pkg/controller/component/vars.go
Outdated
| @@ -340,6 +340,9 @@ func resolveClusterObjectRefVars(ctx context.Context, cli client.Reader, synthes | |||
| } | |||
| vars1, vars2 := make([]corev1.EnvVar, 0), make([]corev1.EnvVar, 0) | |||
| for _, v := range definedVars { | |||
| if len(v.Value) > 0 && v.ValueFrom != nil { | |||
There was a problem hiding this comment.
Perform this check in the cmpd controller.
There was a problem hiding this comment.
Perform this check in the cmpd controller.
done
github-actions
bot
added
size/M
github-actions
bot
added
size/S
leon-inf
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.