Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor parameters partV: decouple apps dependence on parameters and tidy up #8620

Open
wants to merge 1 commit into
base: support/improvement-parameters-api-part2
Choose a base branch
from

Conversation

sophon-zt
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 59.08046% with 178 lines in your changes missing coverage. Please review.

Project coverage is 59.97%. Comparing base (0d108f2) to head (6f0dff5).

Files with missing lines Patch % Lines
controllers/parameters/reconcile_task.go 60.00% 33 Missing and 15 partials ⚠️
.../parameters/componentdrivenparameter_controller.go 66.90% 35 Missing and 12 partials ⚠️
...trollers/apps/transformer_component_reconfigure.go 62.33% 22 Missing and 7 partials ⚠️
pkg/controller/configuration/config_utils.go 0.00% 22 Missing ⚠️
pkg/controller/configuration/template_validate.go 32.14% 19 Missing ⚠️
pkg/controller/configuration/template_render.go 69.23% 8 Missing and 4 partials ⚠️
controllers/apps/component_controller.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##           support/improvement-parameters-api-part2    #8620      +/-   ##
============================================================================
- Coverage                                     60.05%   59.97%   -0.08%     
============================================================================
  Files                                           383      381       -2     
  Lines                                         45478    45238     -240     
============================================================================
- Hits                                          27312    27133     -179     
+ Misses                                        15589    15551      -38     
+ Partials                                       2577     2554      -23     
Flag Coverage Δ
unittests 59.97% <59.08%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part2 branch from 75ef901 to 0d108f2 Compare December 11, 2024 07:01
@sophon-zt sophon-zt force-pushed the support/improvement-parameters-api-part3 branch from 49d7667 to 6f0dff5 Compare December 11, 2024 07:06
@sophon-zt sophon-zt marked this pull request as ready for review December 11, 2024 08:53
@sophon-zt sophon-zt requested review from leon-inf, Y-Rookie and a team as code owners December 11, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant