Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DP_DB_HOST env is missing #8605

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

gnolong
Copy link
Contributor

@gnolong gnolong commented Dec 6, 2024

fix #8604

@gnolong gnolong requested review from ldming, wangyelei, zjx20 and a team as code owners December 6, 2024 09:56
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 6, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.75%. Comparing base (4c88ae8) to head (b9773de).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/dataprotection/restore/builder.go 53.33% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8605      +/-   ##
==========================================
+ Coverage   60.19%   60.75%   +0.56%     
==========================================
  Files         378      378              
  Lines       45901    46034     +133     
==========================================
+ Hits        27630    27968     +338     
+ Misses      15690    15481     -209     
- Partials     2581     2585       +4     
Flag Coverage Δ
unittests 60.75% <53.33%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot removed the approved PR Approved Test label Dec 9, 2024
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Dec 9, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Dec 9, 2024
@gnolong gnolong merged commit a88ad31 into main Dec 9, 2024
35 checks passed
@gnolong gnolong deleted the bugfix/restore-workload-host-env-miss branch December 9, 2024 02:51
@github-actions github-actions bot added this to the Release 0.9.2 milestone Dec 9, 2024
@zjx20
Copy link
Contributor

zjx20 commented Dec 9, 2024

/cherry-pick release-1.0-beta

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12230302187

apecloud-bot pushed a commit that referenced this pull request Dec 9, 2024
Co-authored-by: x.zhou <[email protected]>
(cherry picked from commit a88ad31)
@zjx20
Copy link
Contributor

zjx20 commented Dec 9, 2024

/cherry-pick release-0.9

@apecloud-bot
Copy link
Collaborator

🤖 says: Error cherry-picking.

Auto-merging pkg/dataprotection/restore/builder.go
CONFLICT (content): Merge conflict in pkg/dataprotection/restore/builder.go
error: could not apply a88ad31... fix: DP_DB_HOST env is missing (#8605)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

@apecloud-bot
Copy link
Collaborator

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/12230311945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] DP_DB_HOST env is missing in restore workloads
5 participants