chore: support kbagent multi ports allocate hostnetwork port #8565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/XS
zjx20
approved these changes
Dec 3, 2024
| if err != nil { | ||
| return nil, err | ||
| return nil, fmt.Errorf("failed to allocate port for container %s, port %s: %v", | ||
| container.Name, port.Name, err) |
There was a problem hiding this comment.
the order of params is incorrect.
| return nil, err | ||
| if err := pm.UsePort(portKey, port.ContainerPort); err != nil { | ||
| return nil, fmt.Errorf("failed to use port for container %s, port %s: %v", | ||
| container.Name, port.Name, err) |
leon-inf
approved these changes
Dec 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8565 +/- ##
==========================================
+ Coverage 60.33% 60.38% +0.05%
==========================================
Files 376 376
Lines 45858 45858
==========================================
+ Hits 27667 27693 +26
+ Misses 15588 15578 -10
+ Partials 2603 2587 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
size/L
zjx20
approved these changes
Dec 3, 2024
|
/cherry-pick release-1.0-beta |
|
🤖 says: cherry pick action finished successfully 🎉! |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
(cherry picked from commit c206d0e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.