-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement cmpd's PolicyRules #8328
Open
cjc7373
wants to merge
31
commits into
main
Choose a base branch
from
feature/rbac-for-component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
17e60fc
wip
cjc7373 8a37f6b
cleanup
cjc7373 8dfd349
wip
cjc7373 a80d8f0
cleanup kubeblocks-kb-agent-pod-role
cjc7373 092e869
refactor
cjc7373 7169d42
unit test
cjc7373 1aea7fe
fix tests
cjc7373 6282bd3
fix tests
cjc7373 b262349
cleanup
cjc7373 ad2e09c
api doc
cjc7373 a57f03b
static check
cjc7373 618a559
doc
cjc7373 b3e4c6f
cleanup
cjc7373 208cf73
fix: wrong kind
cjc7373 155b67a
fix
cjc7373 f472d6f
clean old resources
cjc7373 ea9c0a7
review comments
cjc7373 8416e61
fix test
cjc7373 7581dc6
typo
cjc7373 e5587b3
Merge remote-tracking branch 'origin/main' into feature/rbac-for-comp…
cjc7373 1b7bc7c
clean code
cjc7373 7235c5e
Merge remote-tracking branch 'origin/main' into feature/rbac-for-comp…
cjc7373 5e68101
Merge remote-tracking branch 'origin/main' into feature/rbac-for-comp…
cjc7373 287bb06
refine description
cjc7373 70deaa9
change sa naming rule, share rbac resources among components
cjc7373 8a5a122
fix unit test
cjc7373 f55de76
typo
cjc7373 3bceb13
fix test
cjc7373 8fc1b2f
Merge remote-tracking branch 'origin/main' into feature/rbac-for-comp…
cjc7373 e04467b
clean up
cjc7373 9e56c89
clean up
cjc7373 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should it be handled when the service account is specified by user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not owned by the component controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO a service account specified by user should not be modified by KB, even if it's deleted by user. So kb doesn't need to receive events from these service accounts.