TIKA-4272 add pf4j to tika pipes, decouple Fetcher with Fetcher Config, stop using shade plugin for fetchers #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 16, 2024 14:14
…-docker. plugins were stepping on each other's toes with classpath before.
added 7 commits
August 19, 2024 21:29
…eplace shaded jar
nddipiazza
changed the title
nddipiazza
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tika pipes in production in that the extensible Fetcher objects we have loaded into the Tika Server and Tika Grpc Server would have classpath loading issues with other Fetchers. They need to be purely classpath independent of each other.
In order to fix this, I am attempting to introduce pf4j in this pull.
In this pull, the shade plugin goes completely bye-bye in favor of Maven dependency plugin and assembly plugin.
All Fetchers are now loaded via the plugin manager and classpath pulled in dynamically with a separate classloader than those of other Fetchers.
Some changes come as a result:
So now instead of having in the tika configuration. It's actually because we don't need a full copy of the Fetcher anymore.
So now the fetcherConfig is the only thing stored in the Tika Config and the pf4j plugin manager handles loading the correct Fetcher, and then you send it the configuration that it requires.
So now I'm going into the Tika xml serialization stuff I need to place the FetcherConfig to replace the Fetcher objects previously stored there.