Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Modal): Upgrade Modal component to Antd5 #31420

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

alexandrusoare
Copy link
Contributor

Issue #31402

SUMMARY

Upgrading the Modal component to AntDesign5
Info In order to upgrade it completely I also need the Button component to be upgraded to Antdv5 as there are a lot of footers with custom buttons

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image

After
image

Before
image

After
image

Before
image

After
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.74%. Comparing base (76d897e) to head (af825d4).
Report is 1176 commits behind head on master.

Files with missing lines Patch % Lines
superset/utils/webdriver.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #31420       +/-   ##
===========================================
+ Coverage   60.48%   83.74%   +23.25%     
===========================================
  Files        1931      537     -1394     
  Lines       76236    39068    -37168     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32716    -13398     
+ Misses      28017     6352    -21665     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.75% <0.00%> (-0.42%) ⬇️
javascript ?
mysql 76.44% <33.33%> (?)
postgres 76.53% <33.33%> (?)
presto 53.26% <0.00%> (-0.54%) ⬇️
python 83.74% <33.33%> (+20.25%) ⬆️
sqlite 75.99% <33.33%> (?)
unit 60.88% <0.00%> (+3.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@geido geido force-pushed the alexandrusoare/refactor/antd5-modal branch from 5f1b826 to af825d4 Compare December 13, 2024 10:46
@geido geido force-pushed the alexandrusoare/refactor/antd5-modal branch from af825d4 to a6d6bf9 Compare December 13, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants