-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Modal): Upgrade Modal component to Antd5 #31420
Draft
alexandrusoare
wants to merge
12
commits into
apache:master
Choose a base branch
from
alexandrusoare:alexandrusoare/refactor/antd5-modal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
chore(Modal): Upgrade Modal component to Antd5 #31420
alexandrusoare
wants to merge
12
commits into
apache:master
from
alexandrusoare:alexandrusoare/refactor/antd5-modal
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #31420 +/- ##
===========================================
+ Coverage 60.48% 83.74% +23.25%
===========================================
Files 1931 537 -1394
Lines 76236 39068 -37168
Branches 8568 0 -8568
===========================================
- Hits 46114 32716 -13398
+ Misses 28017 6352 -21665
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
geido
force-pushed
the
alexandrusoare/refactor/antd5-modal
branch
from
December 13, 2024 10:46
5f1b826
to
af825d4
Compare
geido
force-pushed
the
alexandrusoare/refactor/antd5-modal
branch
from
December 13, 2024 11:48
af825d4
to
a6d6bf9
Compare
…com/alexandrusoare/superset into alexandrusoare/refactor/antd5-modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #31402
SUMMARY
Upgrading the Modal component to AntDesign5
Info In order to upgrade it completely I also need the Button component to be upgraded to Antdv5 as there are a lot of footers with custom buttons
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
Before
After
Before
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION