Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pivot Table): Fix column width to respect currency config #31414

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vitor-Avila
Copy link
Contributor

SUMMARY

Fixes #31377.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image

After
image

TESTING INSTRUCTIONS

  1. Create a Pivot table using the cleaned_sales_data dataset.
  2. Create a metric at the dataset level and apply a currency config.
  3. Set country as a column, product_line as a row and use the metric created in the previous step.
  4. Validate that the column width respects the currency config.

ADDITIONAL INFORMATION

  • Has associated issue: Pivot Table doesn't consider metric currency for column width #31377
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins size/XS viz:charts:pivot Related to the Pivot Table charts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pivot Table doesn't consider metric currency for column width
1 participant