Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BW-3310 add dateformat to the email subject #31413

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

US579
Copy link
Contributor

@US579 US579 commented Dec 12, 2024

SUMMARY

Problem
If the subject remains the same, all scheduled reports will be delivered in the same email thread, requiring the recipient to scroll back to the original thread to find the latest email.

However, if a date is included in the email subject, the emails will not be grouped in the same thread. To address this, I propose adding a feature that allows users to specify a date format in the email subject, enabling the email client to correctly thread the emails and display them in a more organized manner.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
Screenshot 2024-12-12 at 11 57 06 am

After
Screenshot 2024-12-12 at 11 57 30 am

Screenshot 2024-12-12 at 12 01 34 pm

TESTING INSTRUCTIONS

set DATE_FORMAT_IN_EMAIL_SUBJECT=True

and add date format in the email subject

Screenshot 2024-12-12 at 11 59 55 am

available date format

https://strftime.org/

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: DATE_FORMAT_IN_EMAIL_SUBJECT (by default is disabled)
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.74%. Comparing base (76d897e) to head (60378db).
Report is 1170 commits behind head on master.

Files with missing lines Patch % Lines
superset/reports/notifications/email.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #31413       +/-   ##
===========================================
+ Coverage   60.48%   83.74%   +23.25%     
===========================================
  Files        1931      537     -1394     
  Lines       76236    39069    -37167     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32717    -13397     
+ Misses      28017     6352    -21665     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.75% <63.63%> (-0.42%) ⬇️
javascript ?
mysql 76.44% <81.81%> (?)
postgres 76.53% <81.81%> (?)
presto 53.26% <63.63%> (-0.54%) ⬇️
python 83.74% <90.90%> (+20.25%) ⬆️
sqlite 75.99% <81.81%> (?)
unit 60.88% <81.81%> (+3.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@US579 US579 force-pushed the feat-allow-dates-format-string-in-superset-heading-and-description branch 2 times, most recently from 0c164a3 to eb04b3a Compare December 12, 2024 03:37
@US579 US579 force-pushed the feat-allow-dates-format-string-in-superset-heading-and-description branch from eb04b3a to 60378db Compare December 12, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants