Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sqllab): duplicate error message #31353

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix(sqllab): duplicate error message #31353

merged 2 commits into from
Dec 9, 2024

Conversation

betodealmeida
Copy link
Member

SUMMARY

Small fix for error messages in SQL Lab being duplicated.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screenshot 2024-12-09 at 10 58 54 AM

After:

Screenshot 2024-12-09 at 10 58 19 AM

TESTING INSTRUCTIONS

Updated tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida marked this pull request as ready for review December 9, 2024 16:47
@dosubot dosubot bot added the sqllab Namespace | Anything related to the SQL Lab label Dec 9, 2024
@betodealmeida betodealmeida changed the title Fix duplicate error message fix (sqllab): duplicate error message Dec 9, 2024
@betodealmeida betodealmeida force-pushed the fix-duplicate-error-message branch from 6687af3 to 9c9443f Compare December 9, 2024 17:04
@betodealmeida betodealmeida changed the title fix (sqllab): duplicate error message fix(sqllab): duplicate error message Dec 9, 2024
@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Dec 9, 2024
@betodealmeida betodealmeida merged commit fc45647 into master Dec 9, 2024
36 of 37 checks passed
@sadpandajoe sadpandajoe removed the review:checkpoint Last PR reviewed during the daily review standup label Dec 10, 2024
@sadpandajoe sadpandajoe deleted the fix-duplicate-error-message branch December 12, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

@justinpark justinpark Awaiting requested review from justinpark

Assignees
No one assigned
Labels
preset-io size/M sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@betodealmeida @geido @sadpandajoe @michael-s-molina