Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(histogram): axis margin padding consistent with other graphs #31335

Merged

Conversation

tatiana-cherne
Copy link
Contributor

@tatiana-cherne tatiana-cherne commented Dec 7, 2024

SUMMARY

Newly introduced histogram graph did not have the ability to adjust x & y axis padding under the customize tab, leading to inconsistent display of chart relative to the rest. It now matches the standard.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2024-12-06 at 9 16 13 AM

Before
Screenshot 2024-12-07 at 1 16 53 AM

After
Screenshot 2024-12-07 at 1 17 25 AM

TESTING INSTRUCTIONS

Deploy code and create histogram graph. Select options under customize tab to adjust axis padding

ADDITIONAL INFORMATION

  • [x ] Has associated issue: Inconsistent Default Padding for Different Charts #31033
  • Required feature flags:
  • [x ] Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the viz:charts:histogram Related to the Histogram chart label Dec 7, 2024
@pull-request-size pull-request-size bot added size/S and removed size/M labels Dec 7, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@tatiana-cherne tatiana-cherne changed the title adding chart title config for histogram fix(histogram): axis margin padding consistent with other graphs Dec 7, 2024
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love PRs that add functionality AND remove lines of code!

@rusackas
Copy link
Member

rusackas commented Dec 9, 2024

Fixed and committed a little linting issue nag, and re-ran CI. Hopefully it passes this time.

Superset uses Git pre-commit hooks courtesy of pre-commit. To install run the following:

pip3 install -r requirements/development.txt
pre-commit install
A series of checks will now run when you make a git commit.

Alternatively it is possible to run pre-commit by running pre-commit manually:

pre-commit run --all-files

@mistercrunch mistercrunch merged commit 73d21a8 into apache:master Dec 9, 2024
33 checks passed
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Dec 12, 2024
sadpandajoe pushed a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins size/S v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch viz:charts:histogram Related to the Histogram chart
Projects
Status: Cherried
Development

Successfully merging this pull request may close these issues.

4 participants