-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(histogram): axis margin padding consistent with other graphs #31335
fix(histogram): axis margin padding consistent with other graphs #31335
Conversation
remove commented out code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love PRs that add functionality AND remove lines of code!
superset-frontend/plugins/plugin-chart-echarts/src/Histogram/controlPanel.tsx
Outdated
Show resolved
Hide resolved
Fixed and committed a little linting issue nag, and re-ran CI. Hopefully it passes this time. Superset uses Git pre-commit hooks courtesy of pre-commit. To install run the following:
Alternatively it is possible to run pre-commit by running pre-commit manually:
|
) Co-authored-by: Evan Rusackas <[email protected]> (cherry picked from commit 73d21a8)
SUMMARY
Newly introduced histogram graph did not have the ability to adjust x & y axis padding under the customize tab, leading to inconsistent display of chart relative to the rest. It now matches the standard.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
Deploy code and create histogram graph. Select options under
customize tab
to adjust axis paddingADDITIONAL INFORMATION
Inconsistent Default Padding for Different Charts #31033