Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Name_column): Make 'Name' column of Saved Query page into links #31312

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

LevisNgigi
Copy link
Contributor

@LevisNgigi LevisNgigi commented Dec 5, 2024

SUMMARY

This change updates the "Name" column on the Saved Query page to render the query names as clickable links. These links redirect users to SQL Lab with the respective saved query preloaded.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

links

TESTING INSTRUCTIONS

  1. Navigate to the Saved Queries page in the application.
  2. Ensure you have at least one saved query in the list. If not, create a new query and save it.
  3. Check that the Name column now displays query names as clickable links.
  4. Click on any query name in the Name column.
    • Verify that the link redirects you to SQL Lab with the corresponding saved query loaded.

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Make Saved Query titles into links  #31011
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@LevisNgigi LevisNgigi changed the title refactor:Make 'Name' column of Saved Query page into links refactor(Name saved query):Make 'Name' column of Saved Query page into links Dec 5, 2024
@LevisNgigi LevisNgigi changed the title refactor(Name saved query):Make 'Name' column of Saved Query page into links refactor(Name_column): Make 'Name' column of Saved Query page into links Dec 5, 2024
Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution!

@mistercrunch mistercrunch merged commit 6af22a9 into apache:master Dec 5, 2024
39 of 42 checks passed
@LevisNgigi
Copy link
Contributor Author

LGTM, thank you for the contribution!

Pleasure is mine.

@geido geido added the preset:bounty Issues that have been selected by Preset and have a bounty attached. label Dec 6, 2024
@mistercrunch
Copy link
Member

Believe me, the pleasure is mutual :) We love love love contribs.

@LevisNgigi LevisNgigi deleted the feature/make-name-links branch December 7, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset:bounty Issues that have been selected by Preset and have a bounty attached. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Saved Query titles into links
3 participants