Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(FilterBar): move the "Add/edit filters" button in the FilterBar to the settings menu #31290

Merged
merged 16 commits into from
Dec 6, 2024
Merged

chore(FilterBar): move the "Add/edit filters" button in the FilterBar to the settings menu #31290

merged 16 commits into from
Dec 6, 2024

Conversation

alexandrusoare
Copy link
Contributor

Fixes #30876

SUMMARY

Filter Bar: Move "Add/Edit Filters" to the Gear Icon

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
image

After
image

Before
image

After
image

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@alexandrusoare alexandrusoare marked this pull request as ready for review December 4, 2024 15:09
@dosubot dosubot bot added the dashboard:native-filters Related to the native filters of the Dashboard label Dec 4, 2024
@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Dec 4, 2024
@geido geido added hold! On hold preset:bounty Issues that have been selected by Preset and have a bounty attached. labels Dec 5, 2024
@sadpandajoe sadpandajoe removed the review:checkpoint Last PR reviewed during the daily review standup label Dec 5, 2024
@geido geido removed the hold! On hold label Dec 6, 2024
@geido geido force-pushed the alexandrusoare/chore/move-filterbar-button branch from 078e30f to 1554358 Compare December 6, 2024 17:45
@geido geido merged commit 079e732 into apache:master Dec 6, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

@kgabryje kgabryje Awaiting requested review from kgabryje

@kasiazjc kasiazjc Awaiting requested review from kasiazjc

@jinghua-qa jinghua-qa Awaiting requested review from jinghua-qa jinghua-qa is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

Assignees
No one assigned
Labels
dashboard:native-filters Related to the native filters of the Dashboard preset:bounty Issues that have been selected by Preset and have a bounty attached. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter Bar: Move "Add/Edit Filters" to the Gear Icon
4 participants
@alexandrusoare @geido @sadpandajoe @michael-s-molina