Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dashboard): Ensure shared label colors are updated #31031

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

geido
Copy link
Member

@geido geido commented Nov 22, 2024

SUMMARY

Follow-up PR for #30646 to ensure that when certain dimensions or metrics are removed or no longer present in the charts, the stored shared_label_colors can detect these changes and reflect the current state. This is achieved by comparing all labels across all charts to infer the shared ones once a Dashboard has rendered all its charts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

  1. Enter an existing Dashboard
  2. Update a chart that has shared labels with other charts
  3. Remove those dimensions/metrics from the chart
  4. Ensure that when going back to the dashboard the dashboard is being updated with current shared label colors (by checking the network activity)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the dashboard:colors Related to the color scheme of the Dashboard label Nov 22, 2024
@michael-s-molina
Copy link
Member

Isn't this a fix instead of a chore?

Copy link
Contributor

@fisjac fisjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@geido
Copy link
Member Author

geido commented Nov 23, 2024

Isn't this a fix instead of a chore?

This wasn't there before so it's not fixing something rather adding. But I agree that fix might be appropriate.

@geido geido changed the title chore(Dashboard): Ensure shared label colors are updated fix(Dashboard): Ensure shared label colors are updated Nov 23, 2024
@geido geido merged commit 91301bc into master Nov 23, 2024
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:colors Related to the color scheme of the Dashboard size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants