Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Cleanup code related to MetadataBar, fix types #31030

Merged
merged 4 commits into from
Nov 22, 2024
Merged

chore: Cleanup code related to MetadataBar, fix types #31030

merged 4 commits into from
Nov 22, 2024

Conversation

kgabryje
Copy link
Member

SUMMARY

Minor refactor to cleanup and DRY MetadataBar and explore and dashboard Header components that use MetadataBar. Also, added some missing types

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

No functional changes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the frontend:refactor Related to refactoring the frontend label Nov 22, 2024
@kgabryje kgabryje merged commit abf3790 into apache:master Nov 22, 2024
34 checks passed
@michael-s-molina
Copy link
Member

Maybe it would be nice to use refactor instead of chore for this type of PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina michael-s-molina is a code owner

Assignees
No one assigned
Labels
frontend:refactor Related to refactoring the frontend size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgabryje @michael-s-molina @geido