Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(GHA): Making the Linkinator STEP non-blocking, rather than the JOB. #30847

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Nov 5, 2024

It's annoying that random link failures cause a scary red X on CI. This is one more modest attempt to clean that up.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Nov 5, 2024
@rusackas
Copy link
Member Author

rusackas commented Nov 5, 2024

Ooooh, looks like it's working! Here you see the green checkmark on the CI step, but ALSO see in the logs that there was a problem:

image

@rusackas rusackas merged commit 683ed0d into master Nov 8, 2024
36 of 37 checks passed
nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants