Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "feat: Adds the Featured Charts dashboard (#28789)" #29766

Closed
wants to merge 1 commit into from

Conversation

sadpandajoe
Copy link
Member

This reverts commit 95706d9.

SUMMARY

Noticed that ephemerals don't have any example data. This reverts the PR that could have caused this in case if we don't find a fix forward before we finish with 4.1

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

In the PR, bring up an ephemeral and verify that examples now show up.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added viz:charts Namespace | Anything related to viz types viz:charts:echarts Related to Echarts labels Jul 29, 2024
@sadpandajoe sadpandajoe changed the title Revert "feat: Adds the Featured Charts dashboard (#28789)" fix: Revert "feat: Adds the Featured Charts dashboard (#28789)" Jul 29, 2024
@sadpandajoe sadpandajoe marked this pull request as draft July 29, 2024 18:17
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.46%. Comparing base (76d897e) to head (c378383).
Report is 797 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #29766      +/-   ##
==========================================
+ Coverage   60.48%   70.46%   +9.98%     
==========================================
  Files        1931     1971      +40     
  Lines       76236    79001    +2765     
  Branches     8568     9027     +459     
==========================================
+ Hits        46114    55671    +9557     
+ Misses      28017    21103    -6914     
- Partials     2105     2227     +122     
Flag Coverage Δ
hive 49.07% <ø> (-0.09%) ⬇️
javascript 58.26% <100.00%> (+0.54%) ⬆️
postgres 76.96% <ø> (?)
presto 53.63% <ø> (-0.18%) ⬇️
python 83.66% <ø> (+20.17%) ⬆️
sqlite 76.47% <ø> (?)
unit 59.91% <ø> (+2.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas marked this pull request as ready for review July 30, 2024 18:09
@rusackas
Copy link
Member

Taking this out of draft state to see if it helps CI pass. If it does (or at least if it gets far enough) I'll spin up an ephemeral to make sure it works as expected :)

@rusackas
Copy link
Member

/testenv up

Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://34.220.99.64:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas
Copy link
Member

Hmm... the epehemeral still doesn't have examples. Maybe this PR isn't the root cause?

@sadpandajoe
Copy link
Member Author

Hmm... the epehemeral still doesn't have examples. Maybe this PR isn't the root cause?

hmm weird. @eschutho were there any other changes from that and the 4.1 branch?

@eschutho
Copy link
Member

eschutho commented Jul 31, 2024

hmm weird. @eschutho were there any other changes from that and the 4.1 branch?

Oh strange. That was the one that I reverted from 4.1, but let me see what else might have changed.

@sadpandajoe sadpandajoe marked this pull request as draft August 5, 2024 18:14
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@sadpandajoe sadpandajoe deleted the joe/revert-pr-28789 branch December 16, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins review:draft size/XXL viz:charts:echarts Related to Echarts viz:charts Namespace | Anything related to viz types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants