-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Revert "feat: Adds the Featured Charts dashboard (#28789)" #29766
Conversation
This reverts commit 95706d9.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29766 +/- ##
==========================================
+ Coverage 60.48% 70.46% +9.98%
==========================================
Files 1931 1971 +40
Lines 76236 79001 +2765
Branches 8568 9027 +459
==========================================
+ Hits 46114 55671 +9557
+ Misses 28017 21103 -6914
- Partials 2105 2227 +122
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Taking this out of draft state to see if it helps CI pass. If it does (or at least if it gets far enough) I'll spin up an ephemeral to make sure it works as expected :) |
/testenv up |
@rusackas Ephemeral environment spinning up at http://34.220.99.64:8080. Credentials are |
Hmm... the epehemeral still doesn't have examples. Maybe this PR isn't the root cause? |
hmm weird. @eschutho were there any other changes from that and the 4.1 branch? |
Oh strange. That was the one that I reverted from 4.1, but let me see what else might have changed. |
Ephemeral environment shutdown and build artifacts deleted. |
This reverts commit 95706d9.
SUMMARY
Noticed that ephemerals don't have any example data. This reverts the PR that could have caused this in case if we don't find a fix forward before we finish with 4.1
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
In the PR, bring up an ephemeral and verify that examples now show up.
ADDITIONAL INFORMATION