Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configuring labels on init job #25681

Closed
wants to merge 3 commits into from

Conversation

roeap
Copy link

@roeap roeap commented Oct 17, 2023

SUMMARY

Allows to configure labels on init-job pods.

At my work we encourage use of Azure Workload identities. These require to set the azure.workload.identity/use: "true" label for the federated credential file to get mounted.

With these changes AAD enabled databases can be used requiring no additional credentials

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Haven't seen any means of testing the helm chart in the repo, but we deployed superset with the current changes, and it worked fine.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please update README with helm-docs

@roeap
Copy link
Author

roeap commented Oct 25, 2023

Sorry I missed that ... docs are updated now.

@rusackas
Copy link
Member

This one seems to have fallen off the map. Sorry about that. @roeap would you mind rebasing, and bumping the docs again? Hopefully we can finally get this through ;)

@villebro
Copy link
Member

So sorry about letting this one fall through the cracks 🙁 I'm closing this in favor of #25681 to get this improvement pushed through ASAP.

@villebro villebro closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants