Add specs for additional menu actions

apache · Aug 22, 2024 · e5d9e67 · e5d9e67
1 parent 31cc493
commit e5d9e67
Show file tree

Hide file tree

Showing 2 changed files with 72 additions and 4 deletions.
diff --git a/superset-frontend/src/components/GridTable/HeaderMenu.test.tsx b/superset-frontend/src/components/GridTable/HeaderMenu.test.tsx
@@ -89,14 +89,24 @@ const mockInvisibleColumn3 = {
   getDataAsCsv: jest.fn().mockReturnValue('csv'),
 } as any as Column;
 
+const mockSetColDef = jest.fn();
+
 const mockGridApi = {
+  autoSizeColumn: jest.fn(),
+  autoSizeAllColumns: jest.fn(),
   setColumnPinned: jest.fn(),
+  getColumn: jest.fn().mockReturnValue({
+    setColDef: mockSetColDef,
+    getColDef: jest.fn().mockReturnValue({}),
+  }),
   getColumns: jest.fn().mockReturnValue([]),
   getDataAsCsv: jest.fn().mockReturnValue('csv'),
   exportDataAsCsv: jest.fn().mockReturnValue('csv'),
   getAllDisplayedColumns: jest.fn().mockReturnValue([]),
+  setColumnsPinned: jest.fn(),
   setColumnsVisible: jest.fn(),
   setColumnVisible: jest.fn(),
+  moveColumns: jest.fn(),
 } as any as GridApi;
 
 const mockedProps = {
@@ -107,13 +117,27 @@ const mockedProps = {
 };
 
 afterEach(() => {
+  mockSetColDef.mockClear();
+  (mockGridApi.getDataAsCsv as jest.Mock).mockClear();
   (mockGridApi.setColumnPinned as jest.Mock).mockClear();
   (mockGridApi.setColumnVisible as jest.Mock).mockClear();
+  (mockGridApi.setColumnsVisible as jest.Mock).mockClear();
+  (mockGridApi.setColumnsPinned as jest.Mock).mockClear();
+  (mockGridApi.autoSizeColumn as jest.Mock).mockClear();
+  (mockGridApi.autoSizeAllColumns as jest.Mock).mockClear();
+  (mockGridApi.moveColumns as jest.Mock).mockClear();
 });
 
-test('renders copy data', () => {
-  const { queryByText } = render(<HeaderMenu {...mockedProps} />);
-  expect(queryByText('Copy')).toBeTruthy();
+test('renders copy data', async () => {
+  const { getByText } = render(<HeaderMenu {...mockedProps} />);
+  fireEvent.click(getByText('Copy'));
+  await waitFor(() =>
+    expect(mockGridApi.getDataAsCsv).toHaveBeenCalledTimes(1),
+  );
+  expect(mockGridApi.getDataAsCsv).toHaveBeenCalledWith({
+    columnKeys: [mockedProps.colId],
+    suppressQuotes: true,
+  });
 });
 
 test('renders buttons pinning both side', () => {
@@ -153,6 +177,15 @@ test('renders unpin on pinned right', () => {
   expect(queryByText('Unpin')).toBeTruthy();
 });
 
+test('renders autosize column', async () => {
+  const { getByText } = render(<HeaderMenu {...mockedProps} />);
+  fireEvent.click(getByText('Autosize Column'));
+  await waitFor(() =>
+    expect(mockGridApi.autoSizeColumn).toHaveBeenCalledTimes(1),
+  );
+  expect(mockSetColDef).toHaveBeenCalledTimes(1);
+});
+
 test('renders unhide when invisible column exists', async () => {
   const { queryByText } = render(
     <HeaderMenu {...mockedProps} invisibleColumns={[mockInvisibleColumn]} />,
@@ -189,6 +222,14 @@ describe('for main menu', () => {
     });
   });
 
+  test('renders autosize column', async () => {
+    const { getByText } = render(<HeaderMenu {...mockedProps} isMain />);
+    fireEvent.click(getByText('Autosize all columns'));
+    await waitFor(() =>
+      expect(mockGridApi.autoSizeAllColumns).toHaveBeenCalledTimes(1),
+    );
+  });
+
   test('renders all unhide all hidden columns when multiple invisible columns exist', async () => {
     render(
       <HeaderMenu
@@ -207,4 +248,25 @@ describe('for main menu', () => {
       true,
     );
   });
+
+  test('reset columns configuration', async () => {
+    const { getByText } = render(
+      <HeaderMenu
+        {...mockedProps}
+        isMain
+        invisibleColumns={[mockInvisibleColumn]}
+      />,
+    );
+    fireEvent.click(getByText('Reset columns'));
+    await waitFor(() =>
+      expect(mockGridApi.setColumnsVisible).toHaveBeenCalledTimes(1),
+    );
+    expect(mockGridApi.setColumnsVisible).toHaveBeenCalledWith(
+      [mockInvisibleColumn],
+      true,
+    );
+    expect(mockGridApi.setColumnsPinned).toHaveBeenCalledTimes(1);
+    expect(mockGridApi.setColumnsPinned).toHaveBeenCalledWith([], null);
+    expect(mockGridApi.moveColumns).toHaveBeenCalledTimes(1);
+  });
 });
diff --git a/superset-frontend/src/components/GridTable/HeaderMenu.tsx b/superset-frontend/src/components/GridTable/HeaderMenu.tsx
@@ -223,7 +223,13 @@ const HeaderMenu: React.FC<Params> = ({
           <IconMenuItem
             onClick={() => {
               const column = api.getColumn(colId);
-              column?.setColDef(column?.getColDef(), { minWidth: undefined });
+              column?.setColDef(
+                {
+                  ...column?.getColDef(),
+                  minWidth: undefined,
+                },
+                column?.getColDef(),
+              );
               api.autoSizeColumn(colId);
             }}
           >