bump to 32.2.1 and minor updates

apache · Oct 2, 2024 · c4ae211 · c4ae211
1 parent 27d2950
commit c4ae211
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 30 deletions.
diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
@@ -126,8 +126,8 @@
     "@visx/xychart": "^3.5.1",
     "abortcontroller-polyfill": "^1.7.5",
     "ace-builds": "^1.35.4",
-    "ag-grid-community": "31.0.3",
-    "ag-grid-react": "31.0.3",
+    "ag-grid-community": "32.2.1",
+    "ag-grid-react": "32.2.1",
     "antd": "4.10.3",
     "antd-v5": "npm:antd@^5.18.0",
     "babel-plugin-typescript-to-proptypes": "^2.0.0",

diff --git a/superset-frontend/src/components/GridTable/Header.test.tsx b/superset-frontend/src/components/GridTable/Header.test.tsx
@@ -83,14 +83,6 @@ test('synchronizes the current sort when sortChanged event occured', async () =>
   expect(sortAsc).toBeInTheDocument();
 });
 
-test('disable menu when enableMenu is false', () => {
-  const { queryByText, queryByTestId } = render(
-    <Header {...mockedProps} enableMenu={false} />,
-  );
-  expect(queryByText(mockedProps.displayName)).toBeTruthy();
-  expect(queryByTestId('mock-dropdown')).toBeFalsy();
-});
-
 test('hide display name for PIVOT_COL_ID', () => {
   const { queryByText } = render(
     <Header

diff --git a/superset-frontend/src/components/GridTable/Header.tsx b/superset-frontend/src/components/GridTable/Header.tsx
@@ -25,7 +25,7 @@ import { PIVOT_COL_ID } from './constants';
 import HeaderMenu from './HeaderMenu';
 
 interface Params {
-  enableMenu?: boolean;
+  enableFilterButton?: boolean;
   enableSorting?: boolean;
   displayName: string;
   column: Column;
@@ -82,7 +82,6 @@ const IconPlaceholder = styled.div`
 `;
 
 const Header: React.FC<Params> = ({
-  enableMenu,
   enableSorting,
   displayName,
   setSort,
@@ -174,7 +173,7 @@ const Header: React.FC<Params> = ({
           )}
         </HeaderCell>
       )}
-      {enableMenu && colId && api && (
+      {colId && api && (
         <HeaderAction
           className={`customHeaderAction${
             colId === PIVOT_COL_ID ? ' main' : ''

diff --git a/superset-frontend/src/components/GridTable/index.tsx b/superset-frontend/src/components/GridTable/index.tsx
@@ -190,7 +190,7 @@ function GridTable<RecordType extends object>({
             -webkit-font-smoothing: antialiased;
           }
           .locked-col {
-            background: var(--ag-header-background-color);
+            background: var(--ag-row-border-color);
             padding: 0;
             text-align: center;
             font-size: calc(var(--ag-font-size) * 0.9);