Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Preview] Struts 7.0.x #792

Draft
wants to merge 306 commits into
base: master
Choose a base branch
from
Draft

[Preview] Struts 7.0.x #792

wants to merge 306 commits into from

Conversation

lukaszlenart
Copy link
Member

@lukaszlenart lukaszlenart commented Nov 15, 2023

SNAPSHOT build is available in ASF Snapshot repository or you can download Nightlies build from here

@lukaszlenart lukaszlenart changed the title [Preview] Struts 7 0 x [Preview] Struts 7.0.x Nov 15, 2023
jdyer1 and others added 28 commits December 16, 2023 10:55
This reverts commit b8b9f8a.
This reverts commit cdb0820.
- update freemarker tests
- eclipse transformer for freemarker
- pom corrections (compiles ok, however, eclipse IDE does not work)
- try shade plugin
This reverts commit deebfc3.
- fix for IncludeTagTest
- use eclipse transformer on sitemesh2
…ysis

Only the main branch is supported by this action
- initial attempt to update references javax>jakarta and get things to compile
- use 10.x version of tomcat jars
- fix things broken with rebase
…ysis

Only the main branch is supported by this action
- fix license header
- upgrade to latest jetty-maven plugin
- remove spurious jetty dependencies from parent pom
- struts showcase fixes (still 1 test failure)
This reverts commit d5e766e.
This reverts commit 1c66e69.
This reverts commit def5254.
- use eclipse transformer for Velocity Tools View and Velocity Tools View Jsp
This reverts commit 1fc70af.
- fix formatting tabs>spaces
- velocity with showcase
- fix formatting
new Employee(1L, "Alan", "Smithee", new Date(), 2000f, true, POSITIONS[0],
TEST_SKILLS[0], null, "alan", LEVELS[0], "Nice guy"),
new Employee(2L, "Robert", "Robson", new Date(), 10000f, false, POSITIONS[1],
TEST_SKILLS[1], List.of(TEST_SKILLS).subList(1, TEST_SKILLS.length), "rob", LEVELS[1], "Smart guy")

Check failure

Code scanning / SonarCloud

Credentials should not be hard-coded

<!--SONAR_ISSUE_KEY:AZLxA2qEuQUMpDMLzD81-->Revoke and change this password, as it is compromised. <p>See more on <a href="https://sonarcloud.io/project/issues?id=apache_struts&issues=AZLxA2qEuQUMpDMLzD81&open=AZLxA2qEuQUMpDMLzD81&pullRequest=792">SonarCloud</a></p>
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8 Security Hotspots
71.1% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants