[Test Only][BUILD] Upgrade sbt to 1.10.5
#48972
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panbingkun
commented
Nov 27, 2024
| @@ -24,6 +24,9 @@ set -e | |||
| FWDIR="$(cd "`dirname "$0"`"/..; pwd)" | |||
| cd "$FWDIR" | |||
|
|
|||
| # Skip maven local resolver. | |||
| export SKIP_LOCAL_M2=true | |||
There was a problem hiding this comment.
We make dev/mima ignore the maven local cache directly, so that the environment and process that all tests depend on are consistent in both GA and local.
|
By using environment variables Based on this discussion coursier/coursier#2942 (comment), @LuciferYang @dongjoon-hyun Can we upgrade |
panbingkun
changed the title
sbt to 1.10.5
LuciferYang
reviewed
Nov 28, 2024
| Resolver.file("ivyLocal", file(Path.userHome.absolutePath + "/.ivy2/local"))(Resolver.ivyStylePatterns) | ||
| ), | ||
| DefaultMavenRepository) ++ | ||
| { if (sys.env.contains("SKIP_LOCAL_M2")) Nil else Seq(Resolver.mavenLocal) } :+ |
There was a problem hiding this comment.
Is there a way to exclude Resolver.mavenLocal when it is explicitly known that the sbt task being executed is mimaReportBinaryIssues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to upgrade sbt from
1.9.3to1.10.5.Why are the changes needed?
After version sbt
1.9.3, if there are corrupt jars under the local (~/. m2), the GA's jobMIMA testwill fail to compile. Based on this, we added an environment variable (SKIP_LOCAL_M2) inSparkBuildto control whether to use theMaven Local Resolvermechanism.Based on this discussion When there is a missing jar in Maven's local repo, it will fail. coursier/coursier#2942 (comment),
coursier(sbtrelies on it) willnotsolve this problem in theshortterm.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.