[Feature][Iceberg] Support custom delete sql for sink savemode #8094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
force-pushed
the
dev-support-iceberg-delete-sql
branch
2 times, most recently
from
6d32ff1
to
555d50c
Compare
Hisoka-X
reviewed
Nov 21, 2024
hailin0
force-pushed
the
dev-support-iceberg-delete-sql
branch
from
555d50c
to
5b67e23
Compare
Hisoka-X
reviewed
Nov 25, 2024
| @@ -76,6 +76,7 @@ libfb303-xxx.jar | |||
| | iceberg.table.upsert-mode-enabled | boolean | no | false | Set to `true` to enable upsert mode, default is `false` | | |||
| | schema_save_mode | Enum | no | CREATE_SCHEMA_WHEN_NOT_EXIST | the schema save mode, please refer to `schema_save_mode` below | | |||
| | data_save_mode | Enum | no | APPEND_DATA | the data save mode, please refer to `data_save_mode` below | | |||
| | custom_sql | string | no | - | Custom `delete` data sql for data save mode. e.g: `delete from ... where ...` | | |||
There was a problem hiding this comment.
Basic lgtm. But I'm a little worried, is that the all connector of not support sql we would use our own sql style to support delete by SQL?
There was a problem hiding this comment.
No, iceberg has a data deletion API that is very similar to the SQL language style, which is the premise for implementing this function.
There was a problem hiding this comment.
Hisoka-X
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
[Iceberg] Support custom delete sql for sink savemode
Does this PR introduce any user-facing change?
Add new config
How was this patch tested?
Added
Check list
New License Guide
release-note.