Log bob deserialization exception for snapshot blobs #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajothomas
force-pushed
the
BlobDeserException
branch
from
bdb95c7 to
5188fa3
Compare
dxichen
reviewed
Oct 9, 2024
samza-core/src/main/java/org/apache/samza/storage/blobstore/util/BlobStoreUtil.java
Outdated
Show resolved
Hide resolved
ajothomas
force-pushed
the
BlobDeserException
branch
from
5188fa3 to
bdae2e0
Compare
dxichen
approved these changes
Oct 9, 2024
xinyuiscool
reviewed
Oct 10, 2024
| .thenApplyAsync(f -> snapshotIndexSerde.fromBytes(indexBlobStream.toByteArray()), executor) | ||
| .handle((snapshotIndex, ex) -> { | ||
| if (ex != null) { | ||
| throw new SamzaException(String.format("Unable to deserialize SnapshotIndex bytes for blob ID: %s", blobId), ex); |
There was a problem hiding this comment.
Seems we might get other kinds of exceptions here, e.g. GET exceptions, so change the log message to be "Unable to get SnapshotIndex ..." ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symptom:
BlobStoreUtildoesn't log the blob id today when it fails to deserialize the snapshot blob. Without the blob id, it is tricky to debug why the deserialization issue happened.Changes:
Tests:
API Changes:
None
Upgrade Instructions:
None
Usage Instructions:
None