Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sbt-license-report #61

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

mdedetrich
Copy link
Contributor

@mdedetrich mdedetrich commented Sep 13, 2023

Adds sbt-license-report. Unfortunately one of our dependencies is using packaging.type which sbt-license-report cannot currently handle (see sbt/sbt-license-report#87) so a workaround for the io.netty.incubator:netty-incubator-codec-native-quic was needed (also see #60 (comment) for context).


// This is here because sbt's ivy resolver doesn't properly support packaging.type when
// resolving via sbt-license-report, see https://github.com/sbt/sbt-license-report/issues/87
val r2dbcPostgres = Seq(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an output of the dependency tree without the overrides which you can use as a confirmation that the versions line up

[info]   |   +-org.postgresql:r2dbc-postgresql:0.9.3.RELEASE
[info]   |     +-com.ongres.scram:client:2.1
[info]   |     | +-com.ongres.scram:common:2.1
[info]   |     |   +-com.ongres.stringprep:saslprep:1.1
[info]   |     |     +-com.ongres.stringprep:stringprep:1.1
[info]   |     |     
[info]   |     +-io.projectreactor.netty:reactor-netty:1.0.24
[info]   |     | +-io.projectreactor.netty.incubator:reactor-netty-incubator-quic:0.0..
[info]   |     | | +-io.netty.incubator:netty-incubator-codec-native-quic:0.0.33.Final

Copy link

@nvollmar nvollmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdedetrich mdedetrich merged commit d5b16f0 into apache:main Sep 14, 2023
19 checks passed
@mdedetrich mdedetrich deleted the add-sbt-license-report branch September 14, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants