Skip to content

Commit

Permalink
enable mima checks (#126)
Browse files Browse the repository at this point in the history
* enable mima checks

* simplify mima check due to CI problems
  • Loading branch information
pjfanning authored Aug 29, 2023
1 parent 09bc009 commit de985de
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 11 deletions.
12 changes: 8 additions & 4 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ addCommandAlias("applyCodeStyle", "+headerCreateAll; scalafmtAll; scalafmtSbt; j

addCommandAlias("verifyDocs", ";+doc ;unidoc ;docs/paradoxBrowse")

val mimaCompareVersion = "1.0.0"

lazy val `pekko-connectors-kafka` =
project
.in(file("."))
Expand All @@ -53,7 +55,8 @@ lazy val core = project
name := "pekko-connectors-kafka",
AutomaticModuleName.settings("org.apache.pekko.kafka"),
libraryDependencies ++= Dependencies.coreDependencies,
mimaPreviousArtifacts := Set.empty, // temporarily disable mima checks
mimaPreviousArtifacts := Set(
organization.value %% name.value % mimaCompareVersion),
mimaBinaryIssueFilters += ProblemFilters.exclude[Problem]("org.apache.pekko.kafka.internal.*"))

lazy val testkit = project
Expand All @@ -68,7 +71,8 @@ lazy val testkit = project
libraryDependencies ++= Dependencies.testKitDependencies.value,
libraryDependencies ++= Seq(
"org.junit.jupiter" % "junit-jupiter-api" % JupiterKeys.junitJupiterVersion.value % Provided),
mimaPreviousArtifacts := Set.empty, // temporarily disable mima checks
mimaPreviousArtifacts := Set(
organization.value %% name.value % mimaCompareVersion),
mimaBinaryIssueFilters += ProblemFilters.exclude[Problem]("org.apache.pekko.kafka.testkit.internal.*"))

lazy val `cluster-sharding` = project
Expand All @@ -82,8 +86,8 @@ lazy val `cluster-sharding` = project
AutomaticModuleName.settings("org.apache.pekko.kafka.cluster.sharding"),
AddMetaInfLicenseFiles.clusterShardingSettings,
libraryDependencies ++= Dependencies.clusterShardingDependencies,
mimaPreviousArtifacts := Set.empty // temporarily disable mima checks
)
mimaPreviousArtifacts := Set(
organization.value %% name.value % mimaCompareVersion))

lazy val tests = project
.dependsOn(core, testkit, `cluster-sharding`)
Expand Down
2 changes: 1 addition & 1 deletion project/build.properties
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.9.3
sbt.version=1.9.4
7 changes: 1 addition & 6 deletions project/plugins.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,9 @@ addSbtPlugin("com.github.sbt" % "sbt-unidoc" % "0.5.0")
addSbtPlugin("com.thoughtworks.sbt-api-mappings" % "sbt-api-mappings" % "3.0.2")
addSbtPlugin("com.typesafe.sbt" % "sbt-site" % "1.4.1")

resolvers += Resolver.jcenterRepo
// allow access to snapshots for pekko-sbt-paradox
resolvers += Resolver.ApacheMavenSnapshotsRepo
updateOptions := updateOptions.value.withLatestSnapshots(false)

// We have to deliberately use older versions of sbt-paradox because current Pekko sbt build
// only loads on JDK 1.8 so we need to bring in older versions of parboiled which support JDK 1.8
addSbtPlugin(("org.apache.pekko" % "pekko-sbt-paradox" % "0.0.0+56-bff08336-SNAPSHOT").excludeAll(
addSbtPlugin(("org.apache.pekko" % "pekko-sbt-paradox" % "1.0.0").excludeAll(
"com.lightbend.paradox", "sbt-paradox",
"com.lightbend.paradox" % "sbt-paradox-apidoc",
"com.lightbend.paradox" % "sbt-paradox-project-info"))
Expand Down

0 comments on commit de985de

Please sign in to comment.