OPENNLP-1646: Remove compiler warnings in AbstractDL and inheriting c…

…lasses (#688)
apache · Nov 17, 2024 · 4d9dab9 · 4d9dab9
1 parent 3feb420
commit 4d9dab9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/opennlp-dl/src/main/java/opennlp/dl/AbstractDL.java b/opennlp-dl/src/main/java/opennlp/dl/AbstractDL.java
@@ -27,6 +27,7 @@
 import java.util.stream.Stream;
 
 import ai.onnxruntime.OrtEnvironment;
+import ai.onnxruntime.OrtException;
 import ai.onnxruntime.OrtSession;
 
 import opennlp.tools.tokenize.Tokenizer;
@@ -68,10 +69,11 @@ public Map<String, Integer> loadVocab(final File vocabFile) throws IOException {
   /**
    * Closes this resource, relinquishing any underlying resources.
    *
-   * @throws Exception If it failed to close.
+   * @throws OrtException Thrown if it failed to close Ort resources.
+   * @throws IllegalStateException Thrown if the underlying resources were already closed.
    */
   @Override
-  public void close() throws Exception {
+  public void close() throws OrtException, IllegalStateException {
     if (session != null) {
       session.close();
     }

diff --git a/opennlp-dl/src/test/java/opennlp/dl/namefinder/NameFinderDLEval.java b/opennlp-dl/src/test/java/opennlp/dl/namefinder/NameFinderDLEval.java
@@ -200,10 +200,8 @@ public void invalidModel() {
 
       final File model = new File("invalid.onnx");
       final File vocab = new File("vocab.txt");
-
-      try (final NameFinderDL nameFinderDL = new NameFinderDL(model, vocab, getIds2Labels(),
-          sentenceDetector)) {
-      }
+      //noinspection resource
+      new NameFinderDL(model, vocab, getIds2Labels(), sentenceDetector);
     });
 
   }