-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add debug info #2911
Feature/add debug info #2911
Conversation
[Experimental Bot, please feedback here] Fill In The Commit Message: This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. Yes, this PR appears to meet the basic NuttX requirements, but is missing some crucial information. Here's a breakdown of what's good and what needs improvement: Strengths:
Weaknesses:
In short: The PR description is a good starting point, but needs significantly more detail in the Impact and Testing sections to be considered complete and ready for review. Providing concrete examples and justifications for each point will greatly increase the likelihood of quick and positive feedback. |
ce5c502
to
b74d82b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @eren-terzioglu :-)
Summary
Related to apache/nuttx#15304
Add debug_info target support to parse and print
sysinfo.h
file which is output file of nxdiag application without flashing it to the device or even enablingSYSTEM_NXDIAG
option. We can use this feature to have more information about user system environment when we are investigating issue. Users only need to run make debug_info on their problematic code.Impact
Common layer change
Testing
esp32c6-devkitc:nsh
config selected and then runmake debug_info
command