Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUTCH-2887 Migrate to JUnit 5 Jupiter #791

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lewismc
Copy link
Member

@lewismc lewismc commented Oct 24, 2023

@lewismc lewismc marked this pull request as draft October 24, 2023 16:39
@lewismc
Copy link
Member Author

lewismc commented Oct 25, 2023

OK, I'm over the bulk of the work here.
A brief synopsis of what has been done so far...

  • new junit5 jupiter dependencies added to ivy.xml
  • All assertions migrated to new org.junit.jupiter.api.Assertions package
  • All annotations migrated to new org.junit.jupiter.api package e.g. @Test
  • @Before and @After no longer exist; migrated to @BeforeEach and @AfterEach
  • @Ignore no longer exists: migrated to @Disabled but we should definitely review these cases and see if we can activate them

I think we may be able to improve test execution by investigate parallel execution but that will come in a subsequent PR

Additionally, loads of tests are failing right now due to my limited understanding of how to migrate from Ant's legacy junit task to the junit5 junitlauncher task.

I think one more push and this PR should be ready for review.

@lewismc lewismc self-assigned this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant