Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stability of Java code completion (sealed) tests. #8066

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Dec 17, 2024

No description provided.

@lahodaj lahodaj added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Dec 17, 2024
@lahodaj lahodaj force-pushed the stabilize-java-cc-tests branch from b6f9dbf to ba04482 Compare December 17, 2024 15:31
@lahodaj lahodaj changed the title Attempting to improve stability of Java code completion (sealed) tests. Improve stability of Java code completion (sealed) tests. Dec 17, 2024
@lahodaj lahodaj requested a review from mbien December 17, 2024 15:31
@lahodaj lahodaj added this to the NB25 milestone Dec 17, 2024
@lahodaj lahodaj marked this pull request as ready for review December 17, 2024 15:32
@mbien
Copy link
Member

mbien commented Dec 17, 2024

could you add those two lines from #8025

// bump tresholds to avoid context dumps from "excessive indexing" warnings
System.setProperty("org.netbeans.modules.parsing.impl.indexing.LogContext$EventType.PATH.treshold", "100");
System.setProperty("org.netbeans.modules.parsing.impl.indexing.LogContext$EventType.MANAGER.treshold", "100");

this gets rid of repeated context dumps which make the log hard to read
https://github.com/apache/netbeans/actions/runs/12376205548/job/34543384322?pr=8066#step:10:7086

@mbien mbien added the CI continuous integration changes label Dec 17, 2024
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all green - one test less to worry about. Thanks a lot for stabilizing the completion tests!

@lahodaj
Copy link
Contributor Author

lahodaj commented Dec 18, 2024

Lets see how this works (and if it work well enough). If this turns out to work OK, maybe we need to generalize the approach, and use it in other tests that do waitScanFinished.

Thanks for the review!

@lahodaj lahodaj merged commit 0a5a17e into apache:master Dec 18, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration changes Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants