Fixing rename for permitted subclasses. #7977
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahodaj
added
Java
|
(Found a problem in the patch.) |
lahodaj
force-pushed
the
sealed-type-rename
branch
from
a77b372 to
d14199a
Compare
|
Should be fixed now, and ready for review. Please let me know what you think! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having something like:
Renaming
Subtypewill not rename the identifier in thepermitsclause. This is because:a) the write model (
CausalDiff) does not supportpermitsb) the indexing does not include the permitted subclasses.
This PR is trying to fix both.