Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update netbeans.icns #7127

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Update netbeans.icns #7127

merged 1 commit into from
Mar 9, 2024

Conversation

mhalachev
Copy link
Contributor

Update NetBeans app icon for macOS to match current design guidelines, as discussed in apache/netbeans-nbpackage#51.

@mhalachev
Update netbeans.icns
d7d144a 
Update NetBeans app icon for macOS to match current design guidelines.
@mbien mbien added UI User Interface ci:no-build [ci] disable CI pipeline labels Mar 2, 2024
@mbien mbien added this to the NB22 milestone Mar 2, 2024
@oyarzun oyarzun mentioned this pull request Mar 5, 2024
Merged
eirikbakke
eirikbakke approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@eirikbakke eirikbakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with me.

@eirikbakke eirikbakke mentioned this pull request Mar 7, 2024
Merged
@oyarzun oyarzun self-requested a review March 7, 2024 13:35
oyarzun
oyarzun approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@oyarzun oyarzun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@oyarzun oyarzun merged commit 550d31c into apache:master Mar 9, 2024
35 checks passed
@mhalachev
Copy link
Contributor Author

Thanks!

@mhalachev mhalachev deleted the update-netbeans-icns branch March 11, 2024 20:01
@mbien mbien mentioned this pull request Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyarzun oyarzun oyarzun approved these changes

@eirikbakke eirikbakke eirikbakke approved these changes

Assignees
No one assigned
Labels
ci:no-build [ci] disable CI pipeline os:macos UI User Interface
Projects
None yet
Milestone
NB22
Development

Successfully merging this pull request may close these issues.
4 participants
@mhalachev @eirikbakke @oyarzun @mbien