Skip to content

Commit

Permalink
Add NetBeans icon to match macOS 11 look and feel
Browse files Browse the repository at this point in the history
  • Loading branch information
oyarzun committed Sep 21, 2021
1 parent e5f2f7c commit 402261b
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions nb/ide.branding/licenseinfo.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
<file>core.startup/src/org/netbeans/core/startup/frame48_dark_nb.gif</file>
<file>core.startup/src/org/netbeans/core/startup/frame_nb.gif</file>
<file>release/netbeans.icns</file>
<file>release/netbeans_mac.icns</file>
<file>release/shortcuts.pdf</file>
<file>release/shortcuts_mac.pdf</file>
<license ref="Apache-2.0-ASF" />
Expand Down
Binary file added nb/ide.branding/release/netbeans_mac.icns
Binary file not shown.
2 changes: 1 addition & 1 deletion nb/ide.launcher/unix/netbeans
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ case "`uname`" in
eval launchNbexec \
--jdkhome '"$netbeans_jdkhome"' \
-J-Xdock:name=NetBeans \
'"-J-Xdock:icon=$basedir/nb/netbeans.icns"' \
'"-J-Xdock:icon=$basedir/nb/netbeans_mac.icns"' \
--branding nb \
--clusters '"$netbeans_clusters"' \
-J-Dnetbeans.importclass=org.netbeans.upgrade.AutoUpgrade \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -907,7 +907,7 @@ public Map<String, Object> getAdditionalSystemIntegrationInfo() {
public static final String ICON_UNIX =
"/netbeans/" + NB_CLUSTER + "/netbeans.png"; // NOI18N
public static final String ICON_MACOSX =
"/netbeans/" + NB_CLUSTER + "/netbeans.icns"; // NOI18N
"/netbeans/" + NB_CLUSTER + "/netbeans_mac.icns"; // NOI18N

public static final String SHORTCUT_FILENAME =
"Apache NetBeans-{display-version}.desktop"; // NOI18N
Expand Down
4 changes: 2 additions & 2 deletions nbbuild/installer/mac/newbuild/netBeans/nbide/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
<filter token="APPVERSION" value="${appversion}"/>
<filter token="VERSION" value="${nbide.version}"/>
<filter token="EXENAME" value="netbeans"/>
<filter token="ICONFILENAME" value="netbeans.icns"/>
<filter token="ICONFILENAME" value="netbeans_mac.icns"/>
<filter token="NB_ID" value="${nb.id}"/>
</filterset>
</copy>
Expand All @@ -67,7 +67,7 @@
</delete>

<echo message="Copying the icon into the correct place" />
<copy file="${appdir}/Contents/Resources/NetBeans/netbeans/${nbClusterDir}/netbeans.icns" todir="${appdir}/Contents/Resources"/>
<copy file="${appdir}/Contents/Resources/NetBeans/netbeans/${nbClusterDir}/netbeans_mac.icns" todir="${appdir}/Contents/Resources"/>

<echo message="Creating native macOS NetBeans launcher ${appdir}/Contents/MacOS/netbeans"/>
<exec executable="swift" failonerror="yes" dir="../../../../../../nb/ide.launcher/macosx">
Expand Down

0 comments on commit 402261b

Please sign in to comment.