feat(duplication): add a new RPC to list duplications for one or multiple tables with specified pattern #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
empiredan
changed the title
acelyc111
reviewed
Dec 5, 2024
| @@ -62,6 +73,10 @@ bool iequals(const char *lhs, const std::string &rhs, size_t n); | |||
| // Decide whether the first n bytes of two memory areas are equal, even if one of them is NULL. | |||
| bool mequals(const void *lhs, const void *rhs, size_t n); | |||
|
|
|||
| error_code pattern_match(const std::string &str, | |||
There was a problem hiding this comment.
There is a similar implementation in bool pegasus_server_impl::validate_filter(...), is it possible to unify to use it?
There was a problem hiding this comment.
OK, seems similar. I've added a TODO comment for this. And corner cases would also be checked later in case some errors occurred.
acelyc111
approved these changes
Dec 6, 2024
foreverneverer
approved these changes
Dec 6, 2024
empiredan
changed the title
empiredan
added a commit
that referenced
this pull request
Dec 12, 2024
…r one or multiple tables (#2165) Based on #2164, this PR is to introduce a new command for Pegasus shell to list the duplications for one or multiple tables of this cluster according to provided table name pattern. This command could list table-level, duplication-level and partition-level info for each duplication. It could also provide summary stats for listed duplications. It could check the progress, which is useful while we want to know if the duplication-based migrations have been finished, or how many decrees have not been duplicated. The duplications that have not been finished could also be listed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the only query API is used for just one table. However, sometimes
we need to query duplications for more than one tables by just a name pattern
(prefix, postfix, regex, etc.). Even we just want to get all of the duplications of
all tables of the cluster, without giving a specific table name. For example, while
migrating all tables to another cluster, we want to query the progress of all the
tables at any time; or, we just care about the tables of one database(with the
prefix of table name as the database name).
Therefore, a new RPC is added to allow listing duplication info of tables whose
names are given by some pattern, such as prefix, postfix, regex(would be
supported in the future), exactly match or even all tables of the cluster.