Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CI): Improve github actions #1791

Merged
merged 5 commits into from
Dec 21, 2023
Merged

chore(CI): Improve github actions #1791

merged 5 commits into from
Dec 21, 2023

Conversation

acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Dec 19, 2023 •
edited
Loading

This patch mainly improve the github actions for CI, including:

  • Separate Java client CI 'test' step into 'build_server' and 'test_java_client'.
    So it's not needed to build server again when retrying to run Java client tests.
  • Encapsulate some actions when build and test servers, including:
    • rebuild_thirdparty_if_needed
    • build_pegasus
    • upload_artifact
    • download_artifact
    • run_server_tests

@acelyc111 acelyc111 changed the title Reduce duplicate code chore(CI): Improve Cpp/Java/Go CIs Dec 19, 2023
@acelyc111 acelyc111 marked this pull request as ready for review December 20, 2023 06:18
@acelyc111 acelyc111 changed the title chore(CI): Improve Cpp/Java/Go CIs chore(CI): Improve github actions Dec 20, 2023
@acelyc111
Copy link
Member Author

acelyc111 commented Dec 20, 2023 •
edited
Loading

The go-client and Java-client CIs are failed which are known issues, we can fix it in another patch.

Failed Java client tests:
TestBasic.testRequestDetail:2868
ReplicaSessionTest.testConnect:179

GehaFearless
GehaFearless previously approved these changes Dec 21, 2023
View reviewed changes
GehaFearless
GehaFearless previously approved these changes Dec 21, 2023
View reviewed changes
empiredan
empiredan reviewed Dec 21, 2023
View reviewed changes
.github/actions/download_artifact/action.yaml Outdated Show resolved Hide resolved
.github/actions/download_artifact/action.yaml Outdated Show resolved Hide resolved
.github/actions/upload_artifact/action.yaml Outdated Show resolved Hide resolved
@acelyc111 acelyc111 merged commit 05466d3 into apache:master Dec 21, 2023
60 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GehaFearless GehaFearless GehaFearless approved these changes

@empiredan empiredan empiredan approved these changes

Assignees
No one assigned
Labels
build github scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acelyc111 @empiredan @GehaFearless