Skip to content

Commit

Permalink
fix: Fix build failure on ARM architecture chips (#2013)
Browse files Browse the repository at this point in the history
Fix build failures like:

1.
```
/bin/ld: /.../thirdparty/output/lib/libcurl.a(libcurl_la-content_encoding.o): in function `brotli_close_writer':
content_encoding.c:(.text+0x2c): undefined reference to `BrotliDecoderDestroyInstance'
```

2.
```
/bin/ld: /.../thirdparty/output/lib/libcurl.a(libcurl_la-easy.o): relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `malloc' which may bind externally can not be used when making a shared object; recompile with -fPIC
/bin/ld: /.../thirdparty/output/lib/libcurl.a(libcurl_la-easy.o)(.text+0x30): unresolvable R_AARCH64_ADR_PREL_PG_HI21 relocation against symbol `malloc'
```

3.
```
/bin/ld: idn.c:(.text+0x34): undefined reference to `idn2_lookup_ul'
```
  • Loading branch information
acelyc111 authored May 22, 2024
1 parent a5498a9 commit d00b251
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions thirdparty/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ ExternalProject_Add(fmt
)

set(CURL_OPTIONS
--enable-shared
--disable-dict
--disable-file
--disable-ftp
Expand All @@ -245,11 +246,12 @@ set(CURL_OPTIONS
--disable-manual
--disable-pop3
--disable-rtsp
--disable-shared
--disable-smtp
--disable-telnet
--disable-tftp
--without-brotli
--without-libidn
--without-libidn2
--without-librtmp
--without-libssh2
--without-ssl
Expand All @@ -261,8 +263,6 @@ if (APPLE)
set(CURL_OPTIONS
${CURL_OPTIONS}
--without-nghttp2
--without-libidn2
--without-brotli
)
endif ()
ExternalProject_Add(curl
Expand Down

0 comments on commit d00b251

Please sign in to comment.