feat(server): enhance transaction in graph server #2686
+454
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
imbajin
changed the title
imbajin
reviewed
Oct 25, 2024
There was a problem hiding this comment.
Can we add more context for the design? (investigation/effect -> before / after)
There was a problem hiding this comment.
Also fix the little conflict in code & run CI
javeme
reviewed
Oct 27, 2024
Comment on lines
73
to
74
| } catch (Throwable e) { | ||
| throw e; |
There was a problem hiding this comment.
don't need to catch if we just re-throw here?
| switch (checkList.getStage()) { | ||
| case "config": { | ||
| configContinue(checkList); | ||
| } |
There was a problem hiding this comment.
can we add some comments that we don't expect break here and explain why
|
@Aph-CUG maybe we need to handle the CI error |
# Conflicts: # hugegraph-server/hugegraph-dist/src/main/java/org/apache/hugegraph/TxScanner.java
dosubot
bot
added
size:L
ok，我最近完善好这个pr |
|
Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need