[GLUTEN-8208][CORE] A new unified approach of source folder isolation for iceberg / hudi / delta with Maven #8198
Conversation
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
changed the title
|
Run Gluten Clickhouse CI on x86 |
|
cc @baibaichen thanks |
backends-velox/pom.xml
Outdated
| <resources> | ||
| <resource> | ||
| <directory>${cpp.releases.dir}</directory> | ||
| <targetPath>${platform}/${arch}</targetPath> |
There was a problem hiding this comment.
Weird. It seems that Intellij IDEA doesn't pick up this line and put the libraries directly under the root resource dir. Investigating.
|
@zhztheplayer thanks, could you please create one issue to track these changes? Thanks, |
zhztheplayer
changed the title
zhztheplayer
force-pushed
the
wip-maven-folder
branch
from
1293012 to
1f69eac
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
|
Hi @zzcclp @baibaichen could you please prioritize review on this patch? since this patch introduced a big change on code footprint and may easily get conflict Thanks, |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
2 similar comments
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
zhztheplayer
force-pushed
the
wip-maven-folder
branch
from
8678d66 to
7ad40ed
Compare
|
Run Gluten Clickhouse CI on x86 |
3 similar comments
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
This reverts commit ae19979.
zhztheplayer
force-pushed
the
wip-maven-folder
branch
from
eb18070 to
3cc55d5
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
|
@lwz9103 @baibaichen Thank you for helping verifying this. |
This patch refactors Maven settings to use a unified method for managing source / resource / test-source folders' profile-based activations.
After the change, all the required data lake extension folders in every Maven module will be toggled on if the relevant Maven profile is enabled. This is configured in the root
pom.xmlso no further settings are needed in each Maven submodule. All the previous settings in Maven submodules will be removed in this PR.The new approach will give all the flexibilities to user since each data lake extension will have its own immediate source folder under each Maven module. Which means, there will be
src-iceberg/src-delta/src-hudion the same level withsrcunderbackend-veloxand any other modules. Each of them is a full-featured maven source folder that consists of Java sources, Scala sources, resources, test sources, etc.