[CORE] Add nativeFilters info for simpleString of scan #8169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI on x86 |
|
@zml1206 Would you like to add an example to demonstrate on the difference made by the change? Thanks! |
Added scan change in PR describe. |
zhztheplayer
approved these changes
Dec 9, 2024
| override def simpleString(maxFields: Int): String = { | ||
| val truncatedOutputString = truncatedString(output, "[", ", ", "]", maxFields) | ||
| val runtimeFiltersString = s"RuntimeFilters: ${runtimeFilters.mkString("[", ",", "]")}" | ||
| val nativeFiltersString = s"nativeFilters: ${filterExprs().mkString("[", ",", "]")}" |
There was a problem hiding this comment.
Nit: Do we prefer NativeFilters than nativeFilters?
There was a problem hiding this comment.
Good catch, thank you.
| key + ": " + StringUtils.abbreviate(redact(value), maxMetadataValueLength) | ||
| } | ||
| val metadataStr = truncatedString(metadataEntries, " ", ", ", "", maxFields) | ||
| val nativeFiltersString = s"nativeFilters: ${filterExprs().mkString("[", ",", "]")}" |
|
Run Gluten Clickhouse CI on x86 |
yikf
pushed a commit
to yikf/incubator-gluten
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SQL:
select l_partkey from lineitem where l_partkey + 1 > 5 and rand() < 0.5Before pr:
V1:
V2:
After pr:
V1:
V2:
How was this patch tested?